Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DescriptionBlockEdit): set description block data if metadata exists, ref #265535 #31

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

razvanMiu
Copy link
Contributor

@razvanMiu razvanMiu commented Jul 2, 2024

No description provided.

@razvanMiu razvanMiu requested review from avoinea and alecghica July 2, 2024 12:19
@razvanMiu razvanMiu changed the title fix(DescriptionBlockEdit): set description block data if metadata exi… fix(DescriptionBlockEdit): set description block data if metadata exists, ref #265535 Jul 2, 2024
@ichim-david ichim-david requested a review from tiberiuichim July 3, 2024 07:23
@tiberiuichim
Copy link
Member

this should not be a useEffect, but compute it as a default value for the schema

@razvanMiu
Copy link
Contributor Author

this should not be a useEffect, but compute it as a default value for the schema

We can't set a default value from the schema because the field that is modified doesn't come from the schema. We are using the TextBlockEdit from slate.

@ichim-david ichim-david self-requested a review July 4, 2024 11:21
@ichim-david ichim-david merged commit ee209cf into master Jul 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants