-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Reduce MessageBus config to have a single host #200
refactor!: Reduce MessageBus config to have a single host #200
Conversation
cffe30d
to
e7d1f2a
Compare
7328a11
to
67d561d
Compare
67d561d
to
78d6cd1
Compare
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 75.38% 75.22% -0.16%
==========================================
Files 20 20
Lines 914 896 -18
==========================================
- Hits 689 674 -15
+ Misses 173 172 -1
+ Partials 52 50 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
78d6cd1
to
353510d
Compare
BREAKING CHANGE: Configuration now only needs single broker host info closes edgexfoundry#196 Signed-off-by: Leonard Goodell <[email protected]>
353510d
to
e8e57f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BREAKING CHANGE: Configuration now only needs single broker host info
closes #196
Signed-off-by: Leonard Goodell [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-messaging/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)