Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Reduce MessageBus config to have a single host #200

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Dec 5, 2022

BREAKING CHANGE: Configuration now only needs single broker host info

closes #196

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-messaging/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) Unit tests suffice
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #200 (e8e57f3) into main (3ead656) will decrease coverage by 0.15%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   75.38%   75.22%   -0.16%     
==========================================
  Files          20       20              
  Lines         914      896      -18     
==========================================
- Hits          689      674      -15     
+ Misses        173      172       -1     
+ Partials       52       50       -2     
Impacted Files Coverage Δ
pkg/types/host_info.go 71.42% <ø> (ø)
internal/pkg/nats/options.go 86.88% <66.66%> (-0.42%) ⬇️
internal/pkg/redis/client.go 87.96% <77.77%> (-1.39%) ⬇️
internal/pkg/mqtt/client_options.go 94.28% <100.00%> (+7.79%) ⬆️
messaging/factory.go 85.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lenny-goodell lenny-goodell marked this pull request as ready for review January 4, 2023 21:08
BREAKING CHANGE: Configuration now only needs single broker host info

closes edgexfoundry#196

Signed-off-by: Leonard Goodell <[email protected]>
Copy link

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit bc4b4ae into edgexfoundry:main Jan 9, 2023
@lenny-goodell lenny-goodell deleted the single-host-config branch January 9, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor client config to a single Host
4 participants