Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add model/DTOs and HTTP client for security-proxy-auth #964

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Dec 24, 2024

Closes #963. Add model/DTOs and HTTP client for security-proxy-auth.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 40.50633% with 47 lines in your changes missing coverage. Please review.

Project coverage is 43.67%. Comparing base (3954224) to head (8d9ce4b).

Files with missing lines Patch % Lines
clients/interfaces/mocks/AuthClient.go 0.00% 41 Missing ⚠️
clients/http/auth.go 75.00% 2 Missing and 2 partials ⚠️
dtos/requests/keydata.go 84.61% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
- Coverage   43.71%   43.67%   -0.04%     
==========================================
  Files         111      116       +5     
  Lines        6693     6772      +79     
==========================================
+ Hits         2926     2958      +32     
- Misses       3532     3576      +44     
- Partials      235      238       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

common/echo_api_constants.go Outdated Show resolved Hide resolved
Closes edgexfoundry#963. Add model/DTOs and HTTP client for security-proxy-auth.

Signed-off-by: Lindsey Cheng <[email protected]>
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit a17a865 into edgexfoundry:main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data model, DTOs, and HTTP client for the security-proxy-auth service
3 participants