Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run WatchForChange in a new thread #362

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix: Run WatchForChange in a new thread #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1802f3
fix: Run WatchForChange in a new thread
lindseysimple Jul 22, 2022
7df31f0
fix: Modify the error message from WatchForChanges
lindseysimple Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bootstrap/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func (cp *Processor) listenForChanges(serviceConfig interfaces.Configuration, co
updateStream := make(chan interface{})
defer close(updateStream)

configClient.WatchForChanges(updateStream, errorStream, serviceConfig.EmptyWritablePtr(), writableKey)
go configClient.WatchForChanges(updateStream, errorStream, serviceConfig.EmptyWritablePtr(), writableKey)
lenny-goodell marked this conversation as resolved.
Show resolved Hide resolved

for {
select {
Expand All @@ -468,7 +468,7 @@ func (cp *Processor) listenForChanges(serviceConfig interfaces.Configuration, co
return

case ex := <-errorStream:
lc.Error(ex.Error())
lc.Errorf("error occurred during listening to the configuration changes: %s", ex.Error())

case raw, ok := <-updateStream:
if !ok {
Expand Down