-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename SecretPath to SecretName #551
Conversation
@lenny-intel please see whether we can fix this issue in 3.0 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 57.64% 57.64%
=======================================
Files 27 27
Lines 2236 2236
=======================================
Hits 1289 1289
Misses 865 865
Partials 82 82
|
@cloudxxx8 , Dang it. :-( We would have to delay the release for this and IMO it isn't worth it for a minor consistency issue. It will have to wait until 4.0. |
@lenny-intel it is a real bug, not a consistency issue, so we can fix it in v3.1. |
@cloudxxx8 , How is this a real bug, rather than a name consistency issue? It is a breaking change to 3.0.0. Should discuss in Planning next week. |
@lenny-intel it's my misunderstanding of the error log. I thought code tried to access We have to change the config or merge this PR in v3.1. |
@FelixTing , since the configuration YAML has the correct name, this is bug fix and not a breaking change as I first thought. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once specifying breaking change is removed.
Signed-off-by: Felix Ting <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix: #550
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)fix: Rename ExternalMqtt.SecretPath to SecretName edgex-docs#1095
Testing Instructions
New Dependency Instructions (If applicable)