fix: Rename ExternalMqtt.SecretPath to SecretName #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Ting <[email protected]>
5 tasks
| @@ -134,7 +134,7 @@ Below are only the additional settings and sections that are specific to Core Co | |||
| | QOS | 0 | Quality of Service 0 (At most once), 1 (At least once) or 2 (Exactly once) | | |||
| | Retain | true | Retain setting for MQTT Connection | | |||
| | SkipCertVerify | false | Indicates if the certificate verification should be skipped | | |||
| | SecretPath | `mqtt` | Name of the path in secret provider to retrieve your secrets. Must be non-blank. | | |||
| | SecretName | `mqtt` | Name of the path in secret provider to retrieve your secrets. Must be non-blank. | | |||
There was a problem hiding this comment.
Name needs to stay as SecretPath since we didn't hold up the release for the breaking change.
lenny-goodell
approved these changes
Jun 5, 2023
lenny-goodell
removed
the
hold
edgex-jenkins
added a commit
that referenced
this pull request
Jun 5, 2023
Signed-off-by: edgex-jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements: