Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adjust to MessageBus config with single broker host info #407

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Jan 2, 2023

This PR is dependent on edgexfoundry/go-mod-messaging#200

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run non-secure edgex stack and stop core data
Build core data with this branch and branch from edgexfoundry/go-mod-messaging#200
Run local core data with DEBUG logging
Verify Core data logs show events received from MessageBus

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell marked this pull request as ready for review January 9, 2023 16:56
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit cd249ec into edgexfoundry:main Jan 9, 2023
@lenny-goodell lenny-goodell deleted the single-mb-host branch January 9, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants