feat: Add bootstrap handler to create Messaging Client with secure options #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
unassigned jpwhitemn, cloudxxx8, bnevis-i, jim-wang-intel and iain-anderson
This was referenced May 5, 2021
This was referenced May 6, 2021
jim-wang-intel
requested changes
May 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 52.47% 58.00% +5.52%
==========================================
Files 11 12 +1
Lines 646 750 +104
==========================================
+ Hits 339 435 +96
- Misses 293 300 +7
- Partials 14 15 +1
Continue to review full report at Codecov.
|
jim-wang-intel
approved these changes
May 6, 2021
|
Unit test failed. |
added 2 commits
May 6, 2021 13:25
…tions Close #224 Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
Signed-off-by: lenny <[email protected]>
@bnevis-i , THX! Fixed. |
cloudxxx8
reviewed
May 7, 2021
bootstrap/messaging/messaging.go
Outdated
| defer wg.Done() | ||
| select { | ||
| case <-ctx.Done(): | ||
| _ = msgClient.Disconnect() |
There was a problem hiding this comment.
it would be safer to write
if (msgClient != nil) {
_ = msgClient.Disconnect()
}
Signed-off-by: lenny <[email protected]>
jim-wang-intel
approved these changes
May 7, 2021
Signed-off-by: lenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other upcoming PRs for SDKs/Services and Core Data depend on this PR.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/master/.github/Contributing.md.
What is the current behavior?
No common bootstrap handler exists
Issue Number: #224
What is the new behavior?
Common bootstrap handler now exists
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information