Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add secure MessagBus capability #199

Merged
merged 3 commits into from
May 11, 2021

Conversation

lenny-goodell
Copy link
Member

The PR is dependent on:

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/master/.github/CONTRIBUTING.md

What is the current behavior?

Secure MessageBus capability does not exists

Issue Number: #198

What is the new behavior?

Secure MessageBus capability now exists

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Other information

cloudxxx8
cloudxxx8 previously approved these changes May 10, 2021
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after upgrading to the latest Device SDK

cmd/res/configuration.toml Outdated Show resolved Hide resolved
@lenny-goodell lenny-goodell requested a review from cloudxxx8 May 10, 2021 17:36
@lenny-goodell lenny-goodell linked an issue May 10, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #199 (c04e4a6) into master (f4aebf8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   55.73%   55.73%           
=======================================
  Files          13       13           
  Lines         811      811           
=======================================
  Hits          452      452           
  Misses        311      311           
  Partials       48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aebf8...c04e4a6. Read the comment docs.

Copy link
Member

@iain-anderson iain-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 9699086 into edgexfoundry:master May 11, 2021
@lenny-goodell lenny-goodell deleted the secure-bus branch July 7, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure MessageBus Connection (Device Virtual)
4 participants