Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MQTT and ZeroMQ channels support to support-notification #5035

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jinlinGuan
Copy link
Contributor

@jinlinGuan jinlinGuan commented Dec 23, 2024

close #5007

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

jinlinGuan added a commit to jinlinGuan/ci-build-images that referenced this pull request Dec 24, 2024
@jinlinGuan
Copy link
Contributor Author

recheck

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 4.91071% with 213 lines in your changes missing coverage. Please review.

Project coverage is 27.76%. Comparing base (027efad) to head (e824200).

Files with missing lines Patch % Lines
...upport/notifications/application/channel/sender.go 6.66% 84 Missing ⚠️
.../support/notifications/application/channel/mqtt.go 0.00% 75 Missing ⚠️
...l/support/notifications/application/channel/zmq.go 0.00% 33 Missing ⚠️
internal/support/notifications/init.go 0.00% 9 Missing ⚠️
internal/support/notifications/application/send.go 0.00% 6 Missing ⚠️
.../support/notifications/application/subscription.go 14.28% 5 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5035      +/-   ##
==========================================
- Coverage   28.05%   27.76%   -0.29%     
==========================================
  Files         243      245       +2     
  Lines       17602    17824     +222     
==========================================
+ Hits         4938     4949      +11     
- Misses      11536    11746     +210     
- Partials     1128     1129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit b24805f into edgexfoundry:main Jan 6, 2025
7 checks passed
@jinlinGuan jinlinGuan deleted the issue-5007 branch January 7, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MQTT and ZeroMQ channels support to support-notification
3 participants