style: Enable errcheck linter and associated recommendations #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #3565 Signed-off-by: Bryon Nevis <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
bnevis-i
commented
Sep 30, 2021
| @@ -36,7 +36,7 @@ func distribute(dic *di.Container, n models.Notification) errors.EdgeX { | |||
| } | |||
| for _, address := range sub.Channels { | |||
| // Async transmit the notification to improve the performance | |||
| go transmit(dic, n, sub, address) | |||
| go transmit(dic, n, sub, address) // nolint:errcheck | |||
There was a problem hiding this comment.
Seems clearer to just suppress the error.
bnevis-i
commented
Sep 30, 2021
| @@ -35,7 +35,7 @@ func AddNotification(n models.Notification, ctx context.Context, dic *di.Contain | |||
| addedNotification.Id, | |||
| correlation.FromContext(ctx)) | |||
|
|
|||
| go distribute(dic, addedNotification) | |||
| go distribute(dic, addedNotification) // nolint:errcheck | |||
There was a problem hiding this comment.
Seems clearer to just suppress the error.
bnevis-i
commented
Sep 30, 2021
| @@ -112,7 +112,7 @@ func escalatedSend(dic *di.Container, n models.Notification, trans models.Transm | |||
| } | |||
|
|
|||
| for _, address := range sub.Channels { | |||
| go transmit(dic, escalated, sub, address) | |||
| go transmit(dic, escalated, sub, address) // nolint:errcheck | |||
There was a problem hiding this comment.
Seems clearer to just suppress the error.
|
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3565
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
make test; make docker; make run dev in edgex-compose
New Dependency Instructions (If applicable)