Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Enable staticcheck linter and associated recommendations #3735

Merged
merged 2 commits into from
Sep 29, 2021
Merged

style: Enable staticcheck linter and associated recommendations #3735

merged 2 commits into from
Sep 29, 2021

Conversation

bnevis-i
Copy link
Collaborator

See #3565

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) Not adding functionality
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) Make build test is sufficient
  • I have opened a PR for the related docs change (if not, why?) Not applicable

Testing Instructions

make and make test

@bnevis-i bnevis-i marked this pull request as draft September 29, 2021 15:32
@bnevis-i bnevis-i marked this pull request as ready for review September 29, 2021 15:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

lenny-goodell
lenny-goodell approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim-wang-intel
jim-wang-intel approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit 77fe71b into edgexfoundry:main Sep 29, 2021
@bnevis-i bnevis-i deleted the edgex-go-3565-staticcheck branch September 29, 2021 19:32
@chr1shung chr1shung mentioned this pull request Sep 29, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

@jim-wang-intel jim-wang-intel jim-wang-intel approved these changes

@cloudxxx8 cloudxxx8 Awaiting requested review from cloudxxx8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnevis-i @jim-wang-intel @lenny-goodell