style: Remove dead code and enable deadcode linter (#3731)

See #3565

Signed-off-by: Bryon Nevis <[email protected]>

.golangci.yml

@@ -1,6 +1,5 @@
 linters:
   disable:
-    - deadcode
     - errcheck
     - gosimple
     - ineffassign

internal/core/command/controller/http/command_test.go

@@ -45,8 +45,6 @@ const (
 	testSourceName        = "testSourceName"
 	testDeviceServiceName = "testDeviceService"
 	testCommandName       = "testCommand"
-	testPathPrefix        = common.ApiDeviceRoute + "/" + common.Name + "/" + testDeviceName + "/" + common.Command + "/"
-	testUrl               = "http://localhost:59882"
 	testBaseAddress       = "http://localhost:49990"
 	testQueryStrings      = "a=1&b=2&ds-pushevent=no"
 )

internal/core/data/application/event_test.go

@@ -31,7 +31,6 @@ const (
 	testProfileName        = "TestProfile"
 	testSourceName         = "testSourceName"
 	testUUIDString         = "ca93c8fa-9919-4ec5-85d3-f81b2b6a7bc1"
-	testCreatedTime        = 1600666214495
 	testOriginTime         = 1600666185705354000
 	nonexistentEventID     = "8ad33474-fbc5-11ea-adc1-0242ac120002"
 	testEventCount         = uint32(7778)

internal/core/data/controller/http/event_test.go

@@ -32,7 +32,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-var expectedCorrelationId = uuid.New().String()
 var expectedEventId = uuid.New().String()
 
 var testReading = dtos.BaseReading{

internal/security/kdf/methods_test.go

@@ -10,7 +10,6 @@ import (
 	"crypto/sha256"
 	"encoding/hex"
 	"errors"
-	"io"
 	"os"
 	"testing"
 	"time"
@@ -217,10 +216,6 @@ func TestShortWrite(t *testing.T) {
 // Mock opening and reading of the seed file
 //
 
-func mockFileOpener(name string, flag int, perm os.FileMode) (io.ReadWriteCloser, error) {
-	return &mockSeedFile{}, nil
-}
-
 type mockSeedFile struct {
 	mock.Mock
 }

internal/support/notifications/application/subscription_test.go

@@ -39,7 +39,6 @@ var (
 	testSubscriptionReceiver       = "receiver"
 	testSubscriptionResendLimit    = 5
 	testSubscriptionResendInterval = "10s"
-	unsupportedChannelType         = "unsupportedChannelType"
 )
 
 func mockDic() *di.Container {

internal/support/notifications/controller/http/subscription_test.go

@@ -48,7 +48,6 @@ var (
 	testSubscriptionReceiver       = "receiver"
 	testSubscriptionResendLimit    = 5
 	testSubscriptionResendInterval = "10s"
-	unsupportedChannelType         = "unsupportedChannelType"
 )
 
 func mockDic() *di.Container {

internal/system/executor/commands.go

@@ -23,11 +23,6 @@ import (
 
 const inspect = "inspect"
 
-// messageExecutorCommandFailed returns a text error message and exists to support unit testing.
-func messageExecutorCommandFailed(operationPrefix string, result string, errorMessage string) string {
-	return fmt.Sprintf("%s: %s (%s)", operationPrefix, errorMessage, strings.Replace(result, "\n", " ", -1))
-}
-
 // messageExecutorInspectFailed returns a text error message and exists to support unit testing.
 func messageExecutorInspectFailed(operationPrefix string, errorMessage string) string {
 	return fmt.Sprintf("%s: %s", operationPrefix, errorMessage)

internal/system/executor/docker.go

@@ -25,7 +25,6 @@ const (
 	Restart = "restart"
 	Metrics = "metrics"
 
-	executorType        = "docker"
 	failedStartPrefix   = "Error starting service"
 	failedRestartPrefix = "Error restarting service"
 	failedStopPrefix    = "Error stopping service"

internal/system/executor/docker_test.go

@@ -23,11 +23,10 @@ import (
 )
 
 const (
-	serviceName                   = "serviceName"
-	executableName                = "executableName"
-	errorMessage                  = "errorMessage"
-	metricsSuccessRawResult       = "metricsSuccessRawResult"
-	jsonDecodeFailureErrorMessage = "EOF"
+	serviceName             = "serviceName"
+	executableName          = "executableName"
+	errorMessage            = "errorMessage"
+	metricsSuccessRawResult = "metricsSuccessRawResult"
 )
 
 type executorStubCall struct {