Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: symlink templates file to common-packer #684

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

askb
Copy link
Member

@askb askb commented Sep 8, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Issue Number:

Sandbox Testing

Test Links :

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@askb askb added the 2-medium priority denoting issues with cross-cutting project impact label Sep 8, 2023
@askb askb requested a review from eb-oss September 8, 2023 01:20
Copy link
Member

@eb-oss eb-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag in the commit message needs to be lower case for this project.

@askb askb changed the title CI: Symlink templates to common-packer templates chore: symlink templates file to common-packer Sep 8, 2023
@askb
Copy link
Member Author

askb commented Sep 8, 2023

recheck

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the commit message is now capitalised correctly

@eb-oss eb-oss merged commit 380b547 into edgexfoundry:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-medium priority denoting issues with cross-cutting project impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants