-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20523] Improve IDL parser tests #5559
base: hotfix/ci-submodules
Are you sure you want to change the base?
Conversation
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
2b56c92
to
3faf3c4
Compare
ef3f08b
to
bb1ff44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you please also address the following change?
In Ubuntu 24 the following warning is being thrown:
/root/workspace/Fast-DDS/src/fastdds/src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlPreprocessor.hpp:187:48: error: ignoring attributes on template argument ‘int (*)(FILE*)’ [-Werror=ignored-attributes]
187 | std::unique_ptr<FILE, decltype(&pclose)> pipe(
I tested the following solutions:
Explicit deleter:
using PipeDeleter = int (*)(FILE*);
std::unique_ptr<FILE, PipeDeleter> pipe(
popen(cmd.c_str(), EPROSIMA_PLATFORM_PIPE_OPEN_FLAGS), pclose);
Lambda:
std::unique_ptr<FILE, std::function<void(FILE*)>> pipe(
popen(cmd.c_str(), EPROSIMA_PLATFORM_PIPE_OPEN_FLAGS),
[](FILE* f) { pclose(f); }
);
Signed-off-by: Miguel Company <[email protected]>
I followed a modified version of the lambda approach in cd64d1e |
Signed-off-by: Miguel Company <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This is a follow-up of #4943 that fixes a typo, and also makes cmake generation fail if the submodule with the test IDLs has not been initialized.
Depends on:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist