Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20523] Improve IDL parser tests #5559

Open
wants to merge 6 commits into
base: hotfix/ci-submodules
Choose a base branch
from

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jan 10, 2025

Description

This is a follow-up of #4943 that fixes a typo, and also makes cmake generation fail if the submodule with the test IDLs has not been initialized.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 10, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima January 10, 2025 07:00
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 10, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima January 10, 2025 07:02
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please also address the following change?

In Ubuntu 24 the following warning is being thrown:

/root/workspace/Fast-DDS/src/fastdds/src/cpp/fastdds/xtypes/dynamic_types/idl_parser/IdlPreprocessor.hpp:187:48: error: ignoring attributes on template argument ‘int (*)(FILE*)’ [-Werror=ignored-attributes]
  187 |         std::unique_ptr<FILE, decltype(&pclose)> pipe(

I tested the following solutions:

Explicit deleter:

using PipeDeleter = int (*)(FILE*);
std::unique_ptr<FILE, PipeDeleter> pipe(
    popen(cmd.c_str(), EPROSIMA_PLATFORM_PIPE_OPEN_FLAGS), pclose);

Lambda:

std::unique_ptr<FILE, std::function<void(FILE*)>> pipe(
    popen(cmd.c_str(), EPROSIMA_PLATFORM_PIPE_OPEN_FLAGS), 
    [](FILE* f) { pclose(f); }
);

@MiguelCompany
Copy link
Member Author

I followed a modified version of the lambda approach in cd64d1e

Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany requested review from juanlofer-eprosima and removed request for juanlofer-eprosima January 10, 2025 09:23
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants