Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Why?" and "What?" Section of README.md #9 #22

Merged
merged 48 commits into from
Feb 13, 2022

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jun 15, 2020

On re-re-re-reading the doc, I felt it could be improved. Ref #9

@iteles please take a look and give feedback when you can. 👍
If you're happy with these changes, please merge. :shipit:
Thanks. 🙏

Note: Sorry about the mega update. future changes will be far more incremental. 📝

@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Jun 15, 2020
@nelsonic nelsonic self-assigned this Jun 15, 2020
@nelsonic
Copy link
Member Author

Every time I end up writing too much text I think: this would be fine as a "Blog Post" or an "essay",
but it's way too much to force someone to read for a Product Roadmap ... 💭

README.md Outdated Show resolved Hide resolved
@nelsonic
Copy link
Member Author

@nelsonic nelsonic changed the title Improve "Why?" Section #9 Improve "Why?" and "What?" Section of README.md #9 Aug 24, 2021
@nelsonic nelsonic marked this pull request as ready for review August 24, 2021 09:05
@nelsonic
Copy link
Member Author

@iteles I've fixed the Merge Conflicts on this branch/PR so it's ready for review. ♻️
Please take a look when you have some time. 🙏
Thanks very much. 🌻

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Aug 24, 2021
@nelsonic nelsonic added the help wanted If you can help make progress with this issue, please comment! label Sep 22, 2021
@iteles iteles added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Sep 30, 2021
@nelsonic nelsonic mentioned this pull request Jan 6, 2022
10 tasks
@nelsonic
Copy link
Member Author

nelsonic commented Jan 6, 2022

We all get side-tracked ...

image

image

Staying focussed on-task is a surprisingly hard task for a lot of people. ⏳
If we can help them solve it systematically, it will be a huge hit. 💭

iteles
iteles previously approved these changes Feb 8, 2022
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for taking so long to review this. I started reviewing way back last year and was scattered after that.
Thank you as ever for advancing this @nelsonic and adding to the team motivation in moving this forward!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@iteles
Copy link
Member

iteles commented Feb 8, 2022

@nelsonic Could you please take a quick look and approve/decline the suggested changes and then I'll do the final merge?

nelsonic and others added 8 commits February 8, 2022 12:48
Co-authored-by: Ines Teles Correia <[email protected]>
Co-authored-by: Ines Teles Correia <[email protected]>
Co-authored-by: Ines Teles Correia <[email protected]>
Co-authored-by: Ines Teles Correia <[email protected]>
Co-authored-by: Ines Teles Correia <[email protected]>
@nelsonic
Copy link
Member Author

nelsonic commented Feb 8, 2022

@iteles all your suggestions are applied. Thanks! 🎉

@nelsonic nelsonic assigned iteles and unassigned nelsonic Feb 8, 2022
@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-review Issue or pull request that is currently being reviewed by the assigned person labels Feb 8, 2022
@iteles iteles merged commit c349325 into master Feb 13, 2022
@iteles iteles deleted the update-what-section-issue#9 branch February 13, 2022 15:32
@nelsonic
Copy link
Member Author

Thank you for reviewing/improving & merging this @iteles ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed help wanted If you can help make progress with this issue, please comment!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants