-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] v0.0.1 #3
[PR] v0.0.1 #3
Conversation
Using only base58 and the raw codec.
I am using the However, I was using the IPFS CID inspector to check if the output hash was correctly formatted and it wasn't. Turns out that the Therefore, to make it IPFS-compatible, I went with the other default base32 multicodec available, which was "B" - uppercase base32 with no padding. The package had this option but with padding, so I had to remove that to get it working. Just wanted to share why I'm not using the default, |
Makes sense. Thanks for the update/clarity. 👌 |
Added IPFS tests that create a random file and write random strings and check the hash created with I had a bit of trouble using processes in Dart, I couldn't properly fetch the Going to hand it over for review because the generated |
Marking this as draft and blocked because |
dwyl/dart_multihash#2 merged. |
@LuchoTurtle assign when you feel it's reviewable. (Code is already looking good!) |
Just made the needed changes to get this into a reviewable state. I will update the README with badges once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LuchoTurtle implementation looks good. 🚀
addresses #1
This PR creates a basic version of that creates a
cid
withraw
multicodec andv1
versioning, akin to what's being made with dwyl/cid
.I've noticed that, unlike Elixir and other languages, there isn't a canonical repo that allows users to encode their hash strings with whatever codec they want. . Should be a fun task for another day.
This PR has basic testing and mocks
dwyl/dart_multihash
library, which is waiting to be published. Somultihash
needs to be published first so I can make use of it before publishing this one.It's still in progress, as the README still needs to be written (I don't think there's much need to delve into the topics that are written in dwyl/
cid
, so as to not repeat information. I'll reference it on a "Further reading" basis.I also want to add property based tests from IPFS, but I still need to figure out how to.