Remove ambiguous xrefs to reduce build warnings #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 89.65% 86.70% -2.96%
==========================================
Files 24 24
Lines 1760 1760
==========================================
- Hits 1578 1526 -52
- Misses 182 234 +52 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 24, 2024
randomir
reviewed
Jun 25, 2024
| @@ -548,7 +548,7 @@ def unembed_sampleset(target_sampleset, embedding, source_bqm, | |||
| already exists in the sample set then it is overwritten. | |||
|
|
|||
| Returns: | |||
| :obj:`.SampleSet`: Sample set in the source BQM. | |||
| :obj:`~dimod.SampleSet`: Sample set in the source BQM. | |||
There was a problem hiding this comment.
Using :obj: for classes (instead of :class:) remains such an eyesore to me, to this day. 🤷
randomir
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of sdk, dimod, dwave-cloud-client, and dwave-hybrid PRs to reduce build warnings