-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QPU failover - signal solver failover condition (on resolve) #465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
- Coverage 91.13% 86.36% -4.78%
==========================================
Files 23 23
Lines 1546 1540 -6
==========================================
- Hits 1409 1330 -79
- Misses 137 210 +73
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
`dwave.cloud.Solver.is_software` was renamed in `dwave-cloud-client<0.8`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Change in
DWaveSampler
/DWaveCliqueSampler
behavior: whenfailover=True
is specified on construction, solver failover is only signalled, and the actual failover is left as an exercise for the developer. 😆The "dirty" bit we solve here is SAPI/solver exception unification:
RetryCondition
on sampleset resolve; andFailoverCondition
on sampleset resolve.Note that
RetryCondition
is a specialization ofFailoverCondition
, so catchingFailoverCondition
and doingsampler.trigger_failover()
should handle all failover cases.