-
Notifications
You must be signed in to change notification settings - Fork 6
Publish package automatically (FLAPI-2004) #24
Conversation
Renaming this workflow in preparation for adding a new publishing one.
This workflow will publish the package to https://test.pypi.org to allow the workflow steps to be validated in an isolated manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable so far.
🏁 Successfully published a spurious version to the test version of PyPI in https://github.com/duffelhq/duffel-api-python/runs/4596393584?check_suite_focus=true. |
I'll make the publishing workflow require the test workflow to pass first. |
The criteria for automating the steps required for publishing this package to PyPI are: 1. The test suite should pass first 2. The publish job should only run when a tag is pushed to ensure that versions have matching tags in version control 3. Packages should only be published from `duffelhq/duffel-api-python` to prevent issues for contributors who may fork this repository I'd thought that I could use separate workflows to achieve this but it's immeasurably simpler to do this all in a single workflow.
Reposting the commit message here for visibility! The criteria for automating the steps required for publishing this
I'd thought that I could use separate workflows to achieve this but after spending time in GitHub's documentation for Actions I think that it's immeasurably simpler to do this all in a single workflow. |
Now to test a release! |
Mainly to test the publishing workflow "for real".
🏁 Okay, it all works! |
✅ Successfully published a new version to PyPI using this new workflow job: https://github.com/duffelhq/duffel-api-python/runs/4597586080?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As suggested by @jesse-c, thanks Jesse! Co-authored-by: Jesse Claven <[email protected]>
Norberto, (if you have time!) let me know what you think of this approach. |
Happy with the approach. |
Without this a version string like 1.0.0-rc1 would be skipped.
I changed the workflow name as part of #24 but neglected to change this as well. Mea culpa!
💁 These changes add a new workflow to publish the package to PyPI whenever a new tag is pushed to this repository.
Validation criteria