Skip to content
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.

FLAPI-2022: Implement Offer.Passenger#Update #20

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Dec 17, 2021

We've kept it simple with a function on the existing Offer client as opposed to having a nested Offer.Passenger client.

@jesse-c jesse-c force-pushed the implement-offer.passenger#update branch 2 times, most recently from 0c0b402 to 828baa6 Compare December 17, 2021 14:04
@jesse-c jesse-c marked this pull request as ready for review December 17, 2021 14:05
@jesse-c jesse-c requested review from sgerrand and nlopes and removed request for sgerrand and nlopes December 17, 2021 14:05
@jesse-c jesse-c marked this pull request as draft December 17, 2021 14:06
Copy link
Contributor

@nlopes nlopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that line importing raises has to go, all else looks good.

@jesse-c jesse-c force-pushed the implement-offer.passenger#update branch from b3f5f47 to 58e8f23 Compare December 17, 2021 14:31
We've kept it simple with a function on the existing `Offer` client as
opposed to having a nested `Offer.Passenger` client.
@jesse-c jesse-c force-pushed the implement-offer.passenger#update branch from 58e8f23 to 779edc3 Compare December 17, 2021 14:44
@jesse-c jesse-c marked this pull request as ready for review December 17, 2021 14:44
@jesse-c jesse-c requested a review from sgerrand December 17, 2021 14:44
Copy link
Contributor

@sgerrand sgerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@jesse-c jesse-c merged commit bc0f87a into main Dec 17, 2021
@jesse-c jesse-c deleted the implement-offer.passenger#update branch December 17, 2021 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants