Merge pull request #43 from duffelhq/order-payments-rename-order

Rename `order` method on Payments
duffelhq · Dec 31, 2021 · 7393dbc · 7393dbc
2 parents 1029b92 + 85c1f35
commit 7393dbc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/duffel_api/api/booking/payments.py b/duffel_api/api/booking/payments.py
@@ -35,7 +35,7 @@ def _validate_payment(payment):
         if payment["type"] not in ["arc_bsp_cash", "balance", "payments"]:
             raise PaymentClient.InvalidPaymentType(payment["type"])
 
-    def order_id(self, order_id):
+    def order(self, order_id):
         self._order_id = order_id
         return self
 

diff --git a/tests/test_payments.py b/tests/test_payments.py
@@ -15,7 +15,7 @@ def test_create_payment(requests_mock):
         }
         payment = (
             client.payments.create()
-            .order_id("order-id")
+            .order("order-id")
             .payment(payment_details)
             .execute()
         )
@@ -32,7 +32,7 @@ def test_create_payment_with_invalid_payment_details(requests_mock):
             "currency": "GBP",
             "amount": "30.20",
         }
-        payments_create_client = client.payments.create().order_id("order-id")
+        payments_create_client = client.payments.create().order("order-id")
         with pytest.raises(
             PaymentClient.InvalidPayment,
             match="{'currency': 'GBP', 'amount': '30.20'}",