feat(bluetooth): implement bluetooth support in initrd #1139

bgmilne · 2021-03-01T17:02:11Z

This pull request changes...

Changes

Included a bluetooth module that installs modules, firmware, udev rules and bluetoothd.
systemd and dbus are required by bluetoothd
Include bluetooth by default if BT keyboard or combo found

Checklist

I have tested it locally
For me, this PR improves on Implemented bluetooth support in initrd. #544 in that I can now use Bluetooth keyboards:
- To enter the LUKS passphrase for my root filesystem
- in an rd.break boot (e.g. to also enter my root password the emergency shell prompt).
I have reviewed and updated any documentation if relevant
I am providing new code and test(s) for it

Fixes #270

johannbg · 2021-03-01T17:42:42Z

Please change this PR to a draft. That your own connection fails in your own testing and "others can get it to go a bit further" makes it obviously an incomplete PR...

johannbg

Just did some pre-review, Start by fixing these issues also change your commit msg to feat(bluetooth): implement bluetooth support in initrd so it passes the commisery check.

modules.d/62bluetooth/module-setup.sh

- Included a bluetooth module that installs modules, firmware, udev rules and bluetoothd. - systemd and dbus are required by bluetoothd - Include bluetooth by default if BT keyboard or combo found

bgmilne · 2021-03-21T11:01:10Z

This module is working reliably for me.

Is there anything else blocking this from being merged (the only failed test seems unrelated)?

I'm dismissing this review because the issue in the review have been addressed and github is blocking the merge

tunix · 2022-03-06T21:10:00Z

Hi! I've Fedora Silverblue 35 running on my computer and have the latest updates installed. I tried to enable bluetooth module by adding a file like this:

# cat /etc/dracut.conf.d/ble.conf
add_dracutmodules+=" bluetooth "

And then tried to regenerate initramfs with the following command:

dracut --regenerate-all --force

I can see the bluetooth related files inside initramfs including the files that are probably needed for my keyboard:

# lsinitrd initramfs-5.16.12-200.fc35.x86_64.img |grep bluetooth
bluetooth
drwxr-xr-x   1 root     root            0 Jan  1  1970 etc/bluetooth
-rw-r--r--   1 root     root        10841 Jan  1  1970 etc/bluetooth/main.conf
-rw-r--r--   1 root     root         1182 Jan  1  1970 etc/dbus-1/system.d/bluetooth.conf
drwxr-xr-x   1 root     root            0 Jan  1  1970 etc/systemd/system/bluetooth.target.wants
lrwxrwxrwx   1 root     root           41 Jan  1  1970 etc/systemd/system/bluetooth.target.wants/bluetooth.service -> /usr/lib/systemd/system/bluetooth.service
lrwxrwxrwx   1 root     root           41 Jan  1  1970 etc/systemd/system/dbus-org.bluez.service -> /usr/lib/systemd/system/bluetooth.service
-rwxr-xr-x   1 root     root       288200 Jan  1  1970 usr/bin/bluetoothctl
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/libexec/bluetooth
-rwxr-xr-x   1 root     root      1241576 Jan  1  1970 usr/libexec/bluetooth/bluetoothd
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth
-rw-r--r--   1 root     root        26680 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btbcm.ko.xz
-rw-r--r--   1 root     root        36504 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btintel.ko.xz
-rw-r--r--   1 root     root        29044 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btrtl.ko.xz
-rw-r--r--   1 root     root        46788 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btusb.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth
-rw-r--r--   1 root     root       281012 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/bluetooth.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/bnep
-rw-r--r--   1 root     root        33300 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/bnep/bnep.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/hidp
-rw-r--r--   1 root     root        37252 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/hidp/hidp.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/rfcomm
-rw-r--r--   1 root     root        61760 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/rfcomm/rfcomm.ko.xz
-rw-r--r--   1 root     root          822 Jan  1  1970 usr/lib/systemd/system/bluetooth.service
-rw-r--r--   1 root     root          435 Jan  1  1970 usr/lib/systemd/system/bluetooth.target
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth/58:96:1D:2C:14:4B
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth/58:96:1D:2C:14:4B/34:88:5D:A3:D1:A7
-rw-------   1 root     root          367 Jan  1  1970 var/lib/bluetooth/58:96:1D:2C:14:4B/34:88:5D:A3:D1:A7/info
....
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth/mesh

But when I reboot my computer, it doesn't get paired with the keyboard at LUKS prompt so I can't type my encryption password in. Am I doing something wrong? Do I need to do additional stuff?

Ramen-LadyHKG · 2024-07-01T06:57:40Z

Hi! I've Fedora Silverblue 35 running on my computer and have the latest updates installed. I tried to enable bluetooth module by adding a file like this:

# cat /etc/dracut.conf.d/ble.conf
add_dracutmodules+=" bluetooth "

And then tried to regenerate initramfs with the following command:

dracut --regenerate-all --force

I can see the bluetooth related files inside initramfs including the files that are probably needed for my keyboard:

# lsinitrd initramfs-5.16.12-200.fc35.x86_64.img |grep bluetooth
bluetooth
drwxr-xr-x   1 root     root            0 Jan  1  1970 etc/bluetooth
-rw-r--r--   1 root     root        10841 Jan  1  1970 etc/bluetooth/main.conf
-rw-r--r--   1 root     root         1182 Jan  1  1970 etc/dbus-1/system.d/bluetooth.conf
drwxr-xr-x   1 root     root            0 Jan  1  1970 etc/systemd/system/bluetooth.target.wants
lrwxrwxrwx   1 root     root           41 Jan  1  1970 etc/systemd/system/bluetooth.target.wants/bluetooth.service -> /usr/lib/systemd/system/bluetooth.service
lrwxrwxrwx   1 root     root           41 Jan  1  1970 etc/systemd/system/dbus-org.bluez.service -> /usr/lib/systemd/system/bluetooth.service
-rwxr-xr-x   1 root     root       288200 Jan  1  1970 usr/bin/bluetoothctl
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/libexec/bluetooth
-rwxr-xr-x   1 root     root      1241576 Jan  1  1970 usr/libexec/bluetooth/bluetoothd
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth
-rw-r--r--   1 root     root        26680 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btbcm.ko.xz
-rw-r--r--   1 root     root        36504 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btintel.ko.xz
-rw-r--r--   1 root     root        29044 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btrtl.ko.xz
-rw-r--r--   1 root     root        46788 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/drivers/bluetooth/btusb.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth
-rw-r--r--   1 root     root       281012 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/bluetooth.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/bnep
-rw-r--r--   1 root     root        33300 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/bnep/bnep.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/hidp
-rw-r--r--   1 root     root        37252 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/hidp/hidp.ko.xz
drwxr-xr-x   1 root     root            0 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/rfcomm
-rw-r--r--   1 root     root        61760 Jan  1  1970 usr/lib/modules/5.16.12-200.fc35.x86_64/kernel/net/bluetooth/rfcomm/rfcomm.ko.xz
-rw-r--r--   1 root     root          822 Jan  1  1970 usr/lib/systemd/system/bluetooth.service
-rw-r--r--   1 root     root          435 Jan  1  1970 usr/lib/systemd/system/bluetooth.target
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth/58:96:1D:2C:14:4B
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth/58:96:1D:2C:14:4B/34:88:5D:A3:D1:A7
-rw-------   1 root     root          367 Jan  1  1970 var/lib/bluetooth/58:96:1D:2C:14:4B/34:88:5D:A3:D1:A7/info
....
drwxr-xr-x   1 root     root            0 Jan  1  1970 var/lib/bluetooth/mesh

But when I reboot my computer, it doesn't get paired with the keyboard at LUKS prompt so I can't type my encryption password in. Am I doing something wrong? Do I need to do additional stuff?

would like to know as well

running fedora kernel 6.9.7

bgmilne requested review from danimo, haraldh and johannbg as code owners March 1, 2021 17:02

github-actions bot added modules Issue tracker for all modules needs review labels Mar 1, 2021

bgmilne force-pushed the master branch from 68c69f4 to 9133705 Compare March 1, 2021 18:23

bgmilne marked this pull request as draft March 1, 2021 18:26

bgmilne mentioned this pull request Mar 1, 2021

Add bluetooth module #270

Closed

johannbg requested changes Mar 1, 2021

View reviewed changes

johannbg removed the needs review label Mar 3, 2021

bgmilne force-pushed the master branch 2 times, most recently from 260cf52 to 577a732 Compare March 7, 2021 16:32

bgmilne changed the title ~~Implemented bluetooth support in initrd.~~ feat(bluetooth): implement bluetooth support in initrd Mar 7, 2021

bgmilne force-pushed the master branch from 577a732 to 6d196fe Compare March 7, 2021 16:36

bgmilne marked this pull request as ready for review March 8, 2021 16:57

danimo previously requested changes Mar 10, 2021

View reviewed changes

modules.d/62bluetooth/module-setup.sh Outdated Show resolved Hide resolved

bgmilne force-pushed the master branch 4 times, most recently from 1ed4023 to 9458e4d Compare March 14, 2021 19:56

feat(bluetooth): implement bluetooth support in initrd

1b25d92

- Included a bluetooth module that installs modules, firmware, udev rules and bluetoothd. - systemd and dbus are required by bluetoothd - Include bluetooth by default if BT keyboard or combo found

bgmilne force-pushed the master branch from 9458e4d to 1b25d92 Compare March 14, 2021 19:57

bgmilne requested a review from danimo March 15, 2021 05:53

bgmilne requested a review from johannbg March 27, 2021 10:15

haraldh approved these changes Apr 16, 2021

View reviewed changes

haraldh enabled auto-merge (rebase) April 16, 2021 14:00

johannbg approved these changes Apr 16, 2021

View reviewed changes

johannbg disabled auto-merge April 16, 2021 14:39

johannbg enabled auto-merge (rebase) April 16, 2021 14:41

johannbg merged commit 64ee2a5 into dracutdevs:master Apr 16, 2021

johannbg mentioned this pull request Apr 16, 2021

Implemented bluetooth support in initrd. #544

Closed

Eyenseo mentioned this pull request Dec 1, 2021

Bluetooth support like mkinitcpio-bluetooth anatol/booster#118

Open

irreleph4nt mentioned this pull request Jun 21, 2022

What would be required for this to work with systemd-boot? irreleph4nt/mkinitcpio-bluetooth#13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bluetooth): implement bluetooth support in initrd #1139

feat(bluetooth): implement bluetooth support in initrd #1139

bgmilne commented Mar 1, 2021 •

edited

Loading

johannbg commented Mar 1, 2021

johannbg left a comment

bgmilne commented Mar 21, 2021

tunix commented Mar 6, 2022

Ramen-LadyHKG commented Jul 1, 2024

feat(bluetooth): implement bluetooth support in initrd #1139

feat(bluetooth): implement bluetooth support in initrd #1139

Conversation

bgmilne commented Mar 1, 2021 • edited Loading

Changes

Checklist

johannbg commented Mar 1, 2021

johannbg left a comment

Choose a reason for hiding this comment

bgmilne commented Mar 21, 2021

tunix commented Mar 6, 2022

Ramen-LadyHKG commented Jul 1, 2024

bgmilne commented Mar 1, 2021 •

edited

Loading