-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make features public to enable testing/customization scenarios #411
Conversation
ab21c47
to
b793b2d
Compare
@joperezr I'm making use of the |
src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/HttpResponseAdapterFeature.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters/Adapters/Features/IHttpApplicationFeature.cs
Outdated
Show resolved
Hide resolved
The attribute itself is .NET 8 only, but the feature is built-in to the compiler so the suggestion for downlevel is just to define an internal attribute that looks just like the .NEt 8 one, and the compiler won't care in which assembly it is defined |
Cool. I added an internal one for downlevel then. Since people may be using it on .NET 6 as well, will they not see any compiler warnings? Does it make sense to add an obsolete to that as well (with the diagnostic id?)? |
This exposes the internal features we use to enable System.Web scenarios for two main reasons:
For now, these are marked as experimental using the new ExperimentalAttribute to give us flexibility to change them if we need to since we haven't had to use them outside of our codebase. They have been moved into the
Microsoft.AspNetCore.SystemWebAdapters.Features
namespace as part of this change.Fixes #332