Add build helpers for NuGet packages #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a target to the adapters that will allow making use of Content from older style NuGet packages that don't work with PackageReference. This is done by adding an attribute `CopyContent='true'` to the PackageReference node in the project file, which will cause all the content in the package to be passed into the Content ItemGroup and copied to the output directory.
joperezr
reviewed
Jun 7, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/Build/Microsoft.AspNetCore.SystemWebAdapters.props
Outdated
Show resolved
Hide resolved
|
@jeffkl You helped me develop this a while back, and I'm looking to ship it in this library so that it's easy for customers to consume. Has anything changed on the NuGet side to make this not needed anymore or is it still valuable? |
jeffkl
reviewed
Oct 13, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/Build/NuGetContentFiles.targets
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters/Build/NuGetContentFiles.targets
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters/Build/NuGetContentFiles.targets
Show resolved
Hide resolved
…iles.targets Co-authored-by: Jeff Kluge <[email protected]>
jeffkl
approved these changes
Oct 13, 2023
src/Microsoft.AspNetCore.SystemWebAdapters/Build/NuGetContentFiles.targets
Show resolved
Hide resolved
jeffkl
reviewed
Oct 13, 2023
| <Target Name="AddNugetContentFiles" BeforeTargets="AssignTargetPaths"> | ||
|
|
||
| <!-- Identity PackageReference and paths to packages --> | ||
| <ItemGroup> |
There was a problem hiding this comment.
FYI @rainersigwald so he can see this beautiful hackery 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a target to the adapters that will allow making use of Content from older style NuGet packages that don't work with PackageReference. This is done by adding an attribute
CopyContent='true'to the PackageReference node in the project file, which will cause all the content in the package to be passed into the Content ItemGroup and copied to the output directory.