Connect module exception handling to HttpContext #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpContext/HttpServerUtility had methods related to error handling. When these were added to the adapter, there was no obvious way to implement them, so they were added as no-ops. However, with module support, their utility can be implemented as module events was the main way people interacted with these errors.
Tratcher
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpContext/HttpServerUtility had methods related to error handling.
When these were added to the adapter, there was no obvious way to
implement them, so they were added as no-ops. However, with module
support, their utility can be implemented as module events was the main
way people interacted with these errors.
Part of #280