Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote auth forms test #196

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add remote auth forms test #196

merged 1 commit into from
Sep 9, 2022

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Sep 8, 2022

Playwright tests for RemoteAuth/forms

Copy link
Member

@mjrousos mjrousos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

await Page.Locator(@"text=Log out").ClickAsync();
await Expect(Page.Locator($"text=You have been logged out")).ToBeVisibleAsync();

// Note: Logout on core app doesn't logout framework app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought logging out on the core app did log out on Framework, or did we not update the WebForms sample to do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't update the webforms sample and it would be different since webforms isn't using dataprotection/owin which is the crux of how the mvc apps can do things easily

@HaoK HaoK merged commit f5c1324 into main Sep 9, 2022
@HaoK HaoK deleted the haok/pw2 branch September 9, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants