Add Content-Type as default header that is set #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a default value that it appears some internal teams had relied on and caused problems when they were migrating. This change expands an existing middleware to handle adding any default response headers
mjrousos
approved these changes
Aug 31, 2022
| { | ||
| foreach (var (header, value) in _defaultHeaders) | ||
| { | ||
| if (!context.Response.Headers.ContainsKey(header)) |
There was a problem hiding this comment.
Since we only set headers that aren't already present, should we call _next first so that whatever endpoint handles the request has an opportunity to write headers and we'll only set the default ones if they're still unset after that?
There was a problem hiding this comment.
We can't really do that because after _next(context) the response will have started writing. The alternative would be to register a Response.OnStarting delegate that would handle it there. Let me think about the implications of either.
There was a problem hiding this comment.
That's a good point. I'm ok with keeping this model if it's simpler.
CZEMacLeod
pushed a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 5, 2022
This was a default value that it appears some internal teams had relied on and caused problems when they were migrating. This change expands an existing middleware to handle adding any default response headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a default value that it appears some internal teams had relied on and caused problems when they were migrating. This change expands an existing middleware to handle adding any default response headers