Add a singleton IHttpRuntime to abstract runtime data #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsouthwick
force-pushed
the
tasou/make-runtime-testable
branch
from
d158868 to
355a340
Compare
Currently, anything that relies on HttpRuntime ends up relying on static data that is initialized differently depending on if you're on IIS or not. This change introduces an abstraction so things that require HttpRuntime can build on it in a testable way.
twsouthwick
force-pushed
the
tasou/make-runtime-testable
branch
from
355a340 to
d91ed9c
Compare
mjrousos
approved these changes
Aug 30, 2022
src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/SystemWebAdaptersExtensions.cs
Show resolved
Hide resolved
Tratcher
approved these changes
Aug 30, 2022
HaoK
approved these changes
Aug 30, 2022
CZEMacLeod
pushed a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 5, 2022
Currently, anything that relies on HttpRuntime ends up relying on static data that is initialized differently depending on if you're on IIS or not. This change introduces an abstraction so things that require HttpRuntime can build on it in a testable way.
CZEMacLeod
added a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 5, 2022
CZEMacLeod
added a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 5, 2022
CZEMacLeod
added a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 5, 2022
CZEMacLeod
added a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 7, 2022
CZEMacLeod
added a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 7, 2022
CZEMacLeod
added a commit
to CZEMacLeod/systemweb-adapters
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, anything that relies on HttpRuntime ends up relying on static data that is initialized differently depending on if you're on IIS or not. This change introduces an abstraction so things that require HttpRuntime can build on it in a testable way.