Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework configuring timeout on remote app API #139

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Conversation

mjrousos
Copy link
Member

@mjrousos mjrousos commented Aug 8, 2022

Replaced NetworkTimeout with the ability to just provide an HttpClient as per API review. Also fixed an issue with paths on configured base URLs getting dropped.

Fixes #133
Fixes #138

@mjrousos mjrousos requested a review from twsouthwick August 8, 2022 20:17
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like how it simplifies a few things. I've got a few questions but nothing blocking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants