Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RIDs for Tizen8.0 #94499

Closed
wants to merge 1 commit into from
Closed

Conversation

JongHeonChoi
Copy link
Contributor

No description provided.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 8, 2023
@ghost
Copy link

ghost commented Nov 8, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: JongHeonChoi
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@ViktorHofer
Copy link
Member

Wait, that shouldn't be required anymore in .NET 8 and .NET 9 as we now have portable RID graph. cc @tmds @agocke

@ViktorHofer ViktorHofer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 8, 2023
@tmds
Copy link
Member

tmds commented Nov 8, 2023

Eventually the goal is to remove this (tracked by #90000).

I don't understand why Microsoft.NETCore.App.Runtime.sfxproj opts into the older graph here:

but I assume that's a good reason to keep updating this.

For Linux, these updates happen automagically during source-build.

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 8, 2023

but I assume that's a good reason to keep updating this.

Are we sure we need these Tizen RID updates just for shared framework deps.json file? Would it make sense to require the portable RID graph (which already is the default) when interacting with Tizen RIDs when targeting .NET 8 / .NET 9? cc @jkotas @agocke

From the other thread (cc @elinor-fung):

We don't have a specific release set for removing the switch. I think .NET 9 is a bit too soon though - my thought had been having at least a release of warning that the switch would go away. But yes, once the switch is removed, the non-portable graph could go way.

IMO we should start adding a warning in .NET 9 and then remove the switch with .NET 10. Otherwise we will never be able to stop updating and removing the legacy RID graph.

@tmds
Copy link
Member

tmds commented Nov 8, 2023

Are we sure we need these Tizen RID updates just for shared framework deps.json file? Would it make sense to require the portable RID graph (which already is the default) when interacting with Tizen RIDs when targeting .NET 8 / .NET 9? cc @jkotas @agocke

If this property is just for packing the old graph. Then I fully agree: we don't need to add any more rids and consider the legacy graph unsupported for platforms not yet included.

@ViktorHofer
Copy link
Member

@vitek-karas mentioned here, that the Microsoft.NETCore.App.deps.json includes the full (legacy) RID graph to make that opt-out switch work.

@vitek-karas
Copy link
Member

The idea was that we do need to keep the big RID graph in Microsft.NETCore.App.deps.json to support the legacy behavior, but that we would not keep updating that graph - it would stay at .NET 8 level.

@ViktorHofer
Copy link
Member

Based on that, I'm closing this PR.

@ViktorHofer ViktorHofer closed this Nov 8, 2023
@JongHeonChoi JongHeonChoi deleted the add_tizen80_rid branch November 8, 2023 23:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants