[release/6.0] Add dynamic shim for SSL_CTX_set_options and SSL_set_options #67145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This works around ABI breaking change made between OpenSSL 1.1 and 3.0 where argument type and return type was changed from unsigned long to uint64_t, which caused issues on arm32 architectures with OpenSSL 3.0 installed.
Co-authored-by: Jeremy Barton <[email protected]>
Co-authored-by: Tomas Weinfurt <[email protected]>
|
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsBackport of #67030 to release/6.0 /cc @rzikm Customer ImpactTestingRiskIMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
bartonjs
approved these changes
Mar 25, 2022
|
@rzikm Please fill out the servicing template in the top post. |
|
Windows CI leg failures unrelated ( |
15 tasks
|
@danmoseley this is blocking Ubuntu 22.04 arm32 support -- which patch does it need to get in? |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #67030 to release/6.0
Closes #66310
/cc @rzikm
Customer Impact
An API-breaking change in OpenSSL between 1.1 and 3.0 versions leads to
SslStreambeing unusable on 32-bit platforms with OpenSSL 3.0 or higher (e.g. upcoming Ubuntu 22.04). This transitively affects all facilities built on top ofSslStream, like HTTPS, and by extension, it prevents basic functionality likedotnet restorefrom working, making .NET effectively unusable on affected platforms.Testing
Validated the fix on locally built runtime from this PR and the repro app from the original issue.
Risk
Low - CI run passes on Linux platforms and was the change was manually tested on the configuration affected by the issue.