Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i9/Replace pre-commit manager #20

Merged
merged 11 commits into from
Feb 21, 2022
Merged

i9/Replace pre-commit manager #20

merged 11 commits into from
Feb 21, 2022

Conversation

Dentsor
Copy link
Member

@Dentsor Dentsor commented Jan 19, 2022

Replace husky with pre-commit.com

closes #9

@Dentsor Dentsor requested a review from LarsSelbekk January 19, 2022 20:06
@Dentsor Dentsor self-assigned this Jan 19, 2022
@LarsSelbekk
Copy link
Member

No virtual environment?

@LarsSelbekk
Copy link
Member

Should also use the same configuration for format and pre-commit.

@Dentsor
Copy link
Member Author

Dentsor commented Jan 19, 2022

Depends on #23

@Dentsor Dentsor marked this pull request as draft January 19, 2022 22:52
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Dentsor Dentsor force-pushed the i9/pre-commit branch 3 times, most recently from d7f005d to d2ff923 Compare January 27, 2022 20:23
@Dentsor Dentsor marked this pull request as ready for review January 27, 2022 20:25
@Dentsor
Copy link
Member Author

Dentsor commented Jan 27, 2022

Naming rule violation, IDE1006

One can run all using no parameters or '-Start All',
or Database and API using '-Start Database, API'
Copy link
Member

@LarsSelbekk LarsSelbekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. It doesn't seem like it catches errors funnily enough, but that's out-of-scope I guess.

@Dentsor Dentsor merged commit f9febc6 into master Feb 21, 2022
@Dentsor Dentsor deleted the i9/pre-commit branch February 21, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace pre-commit function and document it
2 participants