Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow using function as table function #2795

Merged
merged 3 commits into from
Dec 17, 2024
Merged

allow using function as table function #2795

merged 3 commits into from
Dec 17, 2024

Conversation

jennifersp
Copy link
Contributor

No description provided.

@jennifersp jennifersp changed the title allow using function and table function allow using function as table function Dec 17, 2024
@jennifersp jennifersp mentioned this pull request Dec 17, 2024
Merged
@jennifersp jennifersp requested a review from fulghum December 17, 2024 17:13
fulghum
fulghum approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just a couple minor comments. I think giving TableFunction a more descriptive name that shows it's adapting a scalar function into a table function would also help.

sql/expression/tablefunction/table_function.go Outdated Show resolved Hide resolved
sql/databases.go Outdated Show resolved Hide resolved
sql/expression/tablefunction/table_function.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit 85adcd5 into main Dec 17, 2024
7 of 8 checks passed
@jennifersp jennifersp deleted the jennifer/table-function branch December 17, 2024 20:56
@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Dec 26, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @fulghum