Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare and convert system types properly #2700

Merged
merged 2 commits into from
Oct 15, 2024
Merged

compare and convert system types properly #2700

merged 2 commits into from
Oct 15, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Oct 14, 2024

Changes:

  • IsType() methods now account for system variable types,
  • coalesce type comparison accounts for system variable types
  • create table from select ... statements account for system variable types

Note: MySQL lists @@admin_port as Integer in their docs, but shows up as UInteger in the CLI

fixes: dolthub/dolt#8448

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The extension to this might be adding tests for other functions, presumably we don't test system types in many other places.

@jycor
Copy link
Contributor Author

jycor commented Oct 15, 2024

regression test fix here: dolthub/doltgresql#856

@jycor jycor merged commit 54bd6d6 into main Oct 15, 2024
7 of 8 checks passed
@jycor jycor deleted the james/coalesce branch October 15, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type inference for COALESCE of system variables
2 participants