Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return limited row issue #731

Merged
merged 2 commits into from
Sep 21, 2024
Merged

fix return limited row issue #731

merged 2 commits into from
Sep 21, 2024

Conversation

jennifersp
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 11789 11790
Failures 30301 30300
Partial Successes1 4788 4788
Main PR
Successful 28.0090% 28.0114%
Failures 71.9910% 71.9886%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

Hydrocharged
Hydrocharged reviewed Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Want to check with you regarding the startup workflow though.

server/connection_handler.go Show resolved Hide resolved
@jennifersp jennifersp merged commit d2c759c into main Sep 21, 2024
13 checks passed
@jennifersp jennifersp deleted the jennifer/regression branch September 21, 2024 01:48
@BrewTestBot BrewTestBot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @Hydrocharged