Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed function resolution for NULLs #530

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fixed function resolution for NULLs #530

merged 1 commit into from
Jul 25, 2024

Conversation

Hydrocharged
Copy link
Collaborator

We had a workaround to allow function resolution to handle NULL expressions (NULL values worked fine since they still resolved to a non-NULL type). This adds the necessary logic so that we no longer need the workaround, and the NULL expression is properly resolved.

@Hydrocharged Hydrocharged requested a review from zachmu July 25, 2024 11:15
@Hydrocharged Hydrocharged enabled auto-merge July 25, 2024 11:17
zachmu
zachmu approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hydrocharged Hydrocharged merged commit 14d3131 into main Jul 25, 2024
12 checks passed
@Hydrocharged Hydrocharged deleted the daylon/function-null branch July 25, 2024 16:56
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu