Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "char" and array types for system functions and tables #519

Merged
merged 11 commits into from
Jul 31, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 changed the title Fix array types for system functions and tables Fix "char" and array types for system functions and tables Jul 26, 2024
@tbantle22 tbantle22 force-pushed the taylor/regtype-arr branch from 09de525 to 30b4168 Compare July 26, 2024 03:36
@tbantle22 tbantle22 force-pushed the taylor/regtype-arr branch from a575088 to c91e018 Compare July 26, 2024 18:24
@tbantle22 tbantle22 requested a review from Hydrocharged July 26, 2024 18:25
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A lot of the comments revolve around casting and quote usage (for clarity).

server/cast/char.go Outdated Show resolved Hide resolved
server/cast/char.go Outdated Show resolved Hide resolved
server/cast/internal_char.go Outdated Show resolved Hide resolved
server/cast/name.go Outdated Show resolved Hide resolved
server/cast/text.go Outdated Show resolved Hide resolved
server/types/char.go Outdated Show resolved Hide resolved
server/types/internal_char.go Outdated Show resolved Hide resolved
server/types/internal_char.go Outdated Show resolved Hide resolved
server/types/internal_char.go Show resolved Hide resolved
server/types/internal_char.go Outdated Show resolved Hide resolved
@tbantle22 tbantle22 merged commit 0241ee4 into main Jul 31, 2024
9 checks passed
@tbantle22 tbantle22 deleted the taylor/regtype-arr branch July 31, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants