Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing new methods from servercfg.DoltgresConfig #1113

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 9, 2025

Implements the new IsUserSpecified() and SkipRootUserInitialization() methods from servercfg.DoltgresConfig, added in dolthub/dolt#8690

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Main PR
covering_index_scan_postgres 370.21/s 369.48/s -0.2%
index_join_postgres 153.03/s 152.53/s -0.4%
index_join_scan_postgres 183.97/s 182.27/s -1.0%
index_scan_postgres 12.54/s 12.35/s -1.6%
oltp_point_select 2781.54/s 2773.47/s -0.3%
oltp_read_only 1877.95/s 1867.68/s -0.6%
select_random_points 112.21/s 111.66/s -0.5%
select_random_ranges 131.12/s 133.95/s +2.1%
table_scan_postgres 11.72/s 11.87/s +1.2%
types_table_scan_postgres 5.42/s 5.60/s +3.3%

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Main PR
Total 42090 42090
Successful 15383 15383
Failures 26707 26707
Partial Successes1 5237 5237
Main PR
Successful 36.5479% 36.5479%
Failures 63.4521% 63.4521%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant