Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap function expressions for generated columns in parens #1108

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 9, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Main PR
covering_index_scan_postgres 368.84/s 369.76/s +0.2%
index_join_postgres 152.81/s 152.69/s -0.1%
index_join_scan_postgres 183.36/s 184.42/s +0.5%
index_scan_postgres 12.53/s 12.51/s -0.2%
oltp_point_select 2781.05/s 2784.74/s +0.1%
oltp_read_only 1877.60/s 1883.25/s +0.3%
select_random_points 112.30/s 112.75/s +0.4%
select_random_ranges 130.98/s 131.72/s +0.5%
table_scan_postgres 11.79/s 11.69/s -0.9%
types_table_scan_postgres 5.61/s 5.55/s -1.1%

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Main PR
Total 42090 42090
Successful 15377 15383
Failures 26713 26707
Partial Successes1 5238 5237
Main PR
Successful 36.5336% 36.5479%
Failures 63.4664% 63.4521%

${\color{lightgreen}Progressions (6)}$

generated

QUERY: CREATE TABLE gtest21a (a int PRIMARY KEY, b int GENERATED ALWAYS AS (nullif(a, 0)) STORED NOT NULL);
QUERY: INSERT INTO gtest21a (a) VALUES (1);
QUERY: CREATE TABLE gtest21b (a int PRIMARY KEY, b int GENERATED ALWAYS AS (nullif(a, 0)) STORED);
QUERY: ALTER TABLE gtest21b ALTER COLUMN b SET NOT NULL;
QUERY: INSERT INTO gtest21b (a) VALUES (1);
QUERY: ALTER TABLE gtest21b ALTER COLUMN b DROP NOT NULL;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@fulghum fulghum requested a review from zachmu January 9, 2025 17:26
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 59e3b9a into main Jan 9, 2025
18 checks passed
@fulghum fulghum deleted the fulghum/paren_wrapping branch January 9, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants