Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1069

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update CONTRIBUTING.md #1069

merged 1 commit into from
Dec 13, 2024

Conversation

macneale4
Copy link
Contributor

The unicode char at the end of the request for stars wasn't rendering. replaced with a ⭐

The unicode char at the end of the request for stars wasn't rendering. replaced with a ⭐
Copy link
Contributor

Main PR
covering_index_scan_postgres 368.33/s 367.00/s -0.4%
index_join_postgres 154.76/s 153.92/s -0.6%
index_join_scan_postgres 185.35/s 184.07/s -0.7%
index_scan_postgres 12.63/s 12.77/s +1.1%
oltp_point_select 2813.23/s 2854.93/s +1.4%
oltp_read_only 1891.15/s 1897.03/s +0.3%
select_random_points 112.64/s 114.79/s +1.9%
select_random_ranges 132.15/s 132.50/s +0.2%
table_scan_postgres 12.12/s 12.10/s -0.2%
types_table_scan_postgres 5.76/s 5.74/s -0.4%

Copy link
Contributor

Main PR
Total 42090 42090
Successful 15344 15344
Failures 26746 26746
Partial Successes1 5232 5232
Main PR
Successful 36.4552% 36.4552%
Failures 63.5448% 63.5448%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macneale4 macneale4 merged commit 278e29b into main Dec 13, 2024
18 checks passed
@macneale4 macneale4 deleted the macneale4/contrib branch December 13, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants