-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started docstring and test coverage on Tag class #329
Conversation
@sveetch nice, thanks! What purpose does the makefile serve? Faster for you to get the project installed? I would personally add it to the gitignore. The fixtures are looking good too. I'm still now completely satisfied with the html statements split into a list of strings, with the big print statement following, but we can revisit it. Are you continuing to work this pr, or can I start merging it in? Thanks! |
@christopherpickering yeah the Makefile is an easy entrypoint to install and performing some tasks around project. I tend to think this is commonly easier for people to quickly manipulate a project, instead of learning poetry or to learn other commands that poetry can not manage. Whatever, i will remove it if you are not confident with it. About the stage of this PR, it is not totally finished, i had some few method to cover for Tag, so don't merge it now, i will see when i can finish it this week, i will get back to you on discord to talk about all of this soon. |
@christopherpickering Ok i've finished the docstring and test coverage on Tag class. Note than:
Edit: Oh yeah also, i've squash my many commits to one (for history consistency) and push forced, so you better be to remove the branch locally, fetch it and create it again. |
Indentation sensitivity is based on element CSS flow. If element is HTML and | ||
have a 'pre' alike flow it is considered as sensitive. | ||
|
||
TODO: It seems '__tag_is_pre' have already been used in 'self.is_pre' from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
Whatever script status is, if ``Tag._is_html`` is ``False`` this will always | ||
return ``False``. | ||
|
||
TODO: <template> element should probably be assumed as a script element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prob keep template separate. The goal of this prop is to allow the contents to be formatted w/ a js formatter, and prevent djlint from touching the contents.
I think the contents of a template tag we are generally safe to format.
Pull Request Check List
re: #168
This is and attempt to improve quality. I've started it from beast_mode as a draft. I made some tests to understand the project code and it leaded to documentation and reference tests so i would be able to know how to contribute to the new parser refactoring.