-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace 'reqid' with 'jeditaskid' for taskid #50
Conversation
@mswiatlo Do you have some current examples that we can use as (manual) API test cases for this PR? Also, are you using |
Thanks @matthewfeickert ! I'm using via git so I'll just pull down the update. I don't have any good ideas for test cases. The problem is that this is user dependent and time dependent. E.g. when I have failed jobs, I do something like:
This requires there be finished jobs that I can then resubmit, and this is how I noticed the problem-- when running the command, I'd get complaints that the tasks I was trying to restart weren't mine. Sorry to not be any help on that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested all this with some jobs? (i.e. the range of jobs option, the dantrim option, and the "normal" way to do things?)
@@ -243,12 +242,12 @@ def getstatus(task, args): | |||
outputString = fmt_string.format( | |||
s=status_color, | |||
t=task['taskname'], | |||
i=task['reqid'], | |||
i=task['jeditaskid'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable here. The only real use for this number is that it's the key to kill the task.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Resolves #49
Suggested squash and merge commit message: