fix: Don't run publishing workflow on tags to avoid errors

[matthewfeickert]

(This is a port of scikit-hep/pylhe#45)

With the old workflow if the publishing workflow was run after a new tag was created

$ bump2version <part>
$ git push origin master --tags

no release would get published to TestPyPI as the workflow that would get kicked off from the push event to master (and so NOT a tag event) would fail the "Verify untagged commits have dev versions" step

pandamonium/.github/workflows/publish-package.yml

Lines 37 to 54 in 3bcfd36

	- name: Verify untagged commits have dev versions
	if: "!startsWith(github.ref, 'refs/tags/')"
	run: |
	latest_tag=$(git describe --tags)
	latest_tag_revlist_SHA=$(git rev-list -n 1 ${latest_tag})
	master_SHA="$(git rev-parse --verify origin/master)"
	wheel_name=$(find dist/ -iname "*.whl" -printf "%f\n")
	if [[ "${latest_tag_revlist_SHA}" != "${master_SHA}" ]]; then # don't check master push events coming from tags
	if [[ "${wheel_name}" == *"pandamonium-0.1.dev"* || "${wheel_name}" != *"dev"* ]]; then
	echo "python-build incorrectly named built distribution: ${wheel_name}"
	echo "python-build is lacking the history and tags required to determine version number"
	echo "intentionally erroring with 'return 1' now"
	return 1
	fi
	else
	echo "Push event to origin/master was triggered by push of tag ${latest_tag}"
	fi
	echo "python-build named built distribution: ${wheel_name}"

as it would

pandamonium/.github/workflows/publish-package.yml

Line 38 in 3bcfd36

if: "!startsWith(github.ref, 'refs/tags/')"

but then also "${wheel_name}" != *"dev"* given that it comes from a tag. So nothing gets published.

Similarly, the workflow that would get kicked off from the tag event will just run though but will pass

pandamonium/.github/workflows/publish-package.yml

Lines 68 to 74 in 3bcfd36

	- name: Publish distribution 📦 to Test PyPI
	# every PR will trigger a push event on master, so check the push event is actually coming from master
	if: github.event_name == 'push' && github.ref == 'refs/heads/master' && github.repository == 'dguest/pandamonium'
	uses: pypa/[email protected]
	with:
	password: ${{ secrets.test_pypi_password }}
	repository_url: https://test.pypi.org/legacy/

as it is has github.ref of 'refs/tags/' and so nothing happens at all.

This PR fixes that by just letting pushes to master publish to TestPyPI and then letting the releases publish to PyPI.

Suggested squash and merge commit message:

* Don't run publishing workflow on tag events
   - Avoid publishing errors due to 'push' or 'tag' events and checks for tags
* Update pypa/gh-action-pypi-publish action to v1.4.1

[matthewfeickert]

@dguest This is ready for review.

[matthewfeickert]

@dguest Done making small text changes now, so this is really ready for review.

[dguest]

I like this because it removes code and apparently also fixes bugs