Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Alpine 3.21 #1277

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

Kaniska244
Copy link
Contributor

Ref: #90

Devcontainer name

base-alpine

Description

This pr adds 3.21 latest alpine version to the supported versions list in base-alpine image.

Changelog

  • Changes are there in manifest.json, Dockerfile and readme.md file for base-alpine image to add support to latest 3.21 alpine version.

Checklist

  • Checked that applied changed work as expected.

@Kaniska244 Kaniska244 marked this pull request as ready for review December 31, 2024 14:35
@Kaniska244 Kaniska244 requested a review from a team as a code owner December 31, 2024 14:35
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this 😄

The changes you added to support version 3.21 look good, however I think you also removed 3.17. Removing 3.17 is handled in a separate PR and shouldn't be lumped in with the work here.

That being said, I merged in your 3.17 EOL PR, so if you merge in the latest from main, the issue should be resolved 👍

@Kaniska244
Copy link
Contributor Author

Thanks for tackling this 😄

The changes you added to support version 3.21 look good, however I think you also removed 3.17. Removing 3.17 is handled in a separate PR and shouldn't be lumped in with the work here.

That being said, I merged in your 3.17 EOL PR, so if you merge in the latest from main, the issue should be resolved 👍

Hi @ddoyle2017 ,

Indeed, my mistake on that. Kindly review it now & let me know in case of any further issues with it.

With Regards,
Kaniska

@ddoyle2017 ddoyle2017 merged commit 67ccd80 into devcontainers:main Jan 9, 2025
2 checks passed
@Kaniska244 Kaniska244 deleted the Alpine_3.20_Upgrade branch January 9, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants