use ReflectionProvider in ParentClassMethodNodeResolver

[staabm]

closes #4163

[TomasVotruba]

Thank you 👍

[staabm]

Testing the fix would requires a autoloader setup etc. Not sure its worth the effort..?

[TomasVotruba]

I'm not sure what you mean exactly.

[staabm]

Didn't realize you already merged the PR. Was asking myself whether the fix could be easily unit tested.. but I don't think so

[TomasVotruba]

Test is always nice :) but this is used in a rule that has few tests. So I think we're good.
I vaguelly recall the reason for native reflection because of parsing internal classes and method body was missing. But since then PHPStan reflection got improved.

We'll see how it perform in the wild with next release 👍

[staabm]

Fyi, next phpstan release will contain bleeding edge rules which warn for this kind of runtime reflection problems

[TomasVotruba]

Good to know, thanks 👍

Btw, how's the the Symplify 11 working?