feat: add no-import-prefix rule #1361
Open
+161
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 29, 2024
Comment on lines
+18
to
+20
| fn tags(&self) -> &'static [&'static str] { | ||
| &[] | ||
| } |
There was a problem hiding this comment.
I'm worrying that ppl will not use this rule because it's not enabled by default. Let's think about a way we could conditionally enable it in deno if we discover deno.json or package.json - in such cases you're not writing a one-off script but have a project and you should centralize dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went a bit back and forth on the name, but I feel like
no-import-prefixmight be clearer thannon-bare-import. Don't have strong feelings about that though.Fixes #1238