Reorganize and another test for directory-permissions handling #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the `mode` supplied to mkdir is subject to the process's umask (here just assumed to be the default 0o022 on Unix, or 0 on Windows).
ry
reviewed
Mar 9, 2020
* denoland/master: use Object instead of Map for promise table (denoland#4309) reorg: move js runtime tests to cli/js/tests/ (denoland#4250) upgrade: dprint 0.8.0 (denoland#4308) reorg: move JS ops implementations to cli/js/ops/, part 3 (denoland#4302) test: add actual error class to fail message (denoland#4305) upgrade: typescript 3.8.3 (denoland#4301) reorg: move JS ops implementations to cli/js/ops/, part 2 (denoland#4283) feat(std/node) add appendFile and appendFileSync (denoland#4294) disable test_raw_tty (denoland#4282)
This was referenced Mar 10, 2020
Closed
Merged
* denoland/master: feat (std/encoding): add binary module (denoland#4274) refactor(cli/js/net): Cleanup iterable APIs (denoland#4236) Add Deno.umask (denoland#4290) refactor: Cleanup options object parameters (denoland#4296) refactor: uncomment tests broken tests, use skip (denoland#4311) Add global "quiet" flag (denoland#4135)
* github/filesystem8d: fix undo typescript changes
|
This could be ready to go, but as with #4287, I implemented it by throwing on Windows if an explicit |
ry
reviewed
Mar 11, 2020
|
Pushed commits undoing the deno_typescript stuff (sorry, not used to working with submodules), and made the |
dubiousjim
added a commit
to dubiousjim/deno
that referenced
this pull request
Mar 13, 2020
* denoland/master: Remove doc strings from cli/js TS files (denoland#4329) upgrade: Rust 1.42.0 (denoland#4331) Enable std tests in debug mode (denoland#4332) fix: Node polyfill fsAppend rework (denoland#4322) v0.36.0 Add waker to StreamResource to fix hang on close bugs (denoland#4293) reorg: Deno global initialization (denoland#4317) move compiler API tests to integration tests (denoland#4319) support permission mode in mkdir (denoland#4286) Stricter permissions for Deno.makeTemp* (denoland#4318) reorg: remove dispatch.ts, move signals, factor out web utils (denoland#4316) reorg: cli/js/compiler/, move more API to cli/js/web/ (denoland#4310) Improve dprint config (denoland#4314) doc(cli/flags): Reduce empty lines in help messages (denoland#4312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs towards #4017.
This PR moves the handling of default permissions for
op_mkdirto Rust (where this also is/will be handled for related operations), improves somedebug!calls for directory-permissions related functions, and adds a test verifying that themodeargument supplied to mkdir is subject to the process's umask.