Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync/async seek returns cursor position #4211

Merged
merged 3 commits into from
Mar 2, 2020
Merged

sync/async seek returns cursor position #4211

merged 3 commits into from
Mar 2, 2020

Conversation

bartossh
Copy link
Contributor

@bartossh bartossh commented Mar 1, 2020

This is good first issue fix

@claassistantio
Copy link

claassistantio commented Mar 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bartossh!

Please make sure to sign the CLA

bartlomieju
bartlomieju previously requested changes Mar 1, 2020
View reviewed changes
cli/js/files.ts Outdated Show resolved Hide resolved
@bartossh bartossh requested a review from bartlomieju March 2, 2020 08:46
ry
ry approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 4a47ffa into denoland:master Mar 2, 2020
@dubiousjim dubiousjim mentioned this pull request Mar 2, 2020
Closed
19 tasks
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Mar 3, 2020
@bartlomieju
seek should return cursor position (denoland#4211)
15847a5
@bartlomieju bartlomieju mentioned this pull request Mar 4, 2020
Closed
mhvsa pushed a commit to mhvsa/deno that referenced this pull request Mar 6, 2020
@mhvsa
seek should return cursor position (denoland#4211)
9782e65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartossh @claassistantio @ry @bartlomieju