Skip to content

Commit

Permalink
build: add windows-2022 to v16.x actions
Browse files Browse the repository at this point in the history
This was reverted in the commit mentioned below due to a
compiler bug. The bug got resolved in MSVC 14.33, which
is part of the GitHub Actions 20220821.1 image for
windows-2022.

Ref: nodejs@79e2ab2
Ref: nodejs#42560
Ref: https://developercommunity.visualstudio.com/t/Failed-to-compile-nodejs-16140-with-la/1682115?space=62&q=nodejs
Ref: https://github.com/actions/runner-images/blob/releases/win22/20220821/images/win/Windows2022-Readme.md
  • Loading branch information
dennisameling committed Aug 23, 2022
1 parent 5c77d77 commit ba4fd72
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ permissions:
jobs:
build-windows:
if: github.event.pull_request.draft == false
runs-on: windows-2019
strategy:
matrix:
windows: [windows-2019, windows-2022]
fail-fast: false
runs-on: ${{ matrix.windows }}
steps:
- uses: actions/checkout@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ permissions:
jobs:
coverage-windows:
if: github.event.pull_request.draft == false
runs-on: windows-2019
runs-on: windows-2022
steps:
- uses: actions/checkout@v3
with:
Expand Down

0 comments on commit ba4fd72

Please sign in to comment.